feat(clerk-js): Render `@clerk/ui` by brkalow · Pull Request #4114 · clerk/javascript

brkalow · 2024-09-05T22:27:51Z

Description

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-09-05T22:27:54Z

🦋 Changeset detected

Latest commit: 1574014

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/elements	Minor
@clerk/clerk-js	Minor
@clerk/nextjs	Minor
@clerk/shared	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/localizations	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

clerk-cookie · 2024-10-04T19:16:20Z

Hey @dstaley - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.3.13-snapshot.v6bae6c3
@clerk/backend	1.13.9-snapshot.v6bae6c3
@clerk/chrome-extension	1.3.16-snapshot.v6bae6c3
@clerk/clerk-js	5.27.0-snapshot.v6bae6c3
@clerk/elements	0.16.0-snapshot.v6bae6c3
@clerk/clerk-expo	2.2.22-snapshot.v6bae6c3
@clerk/express	1.2.2-snapshot.v6bae6c3
@clerk/fastify	1.0.52-snapshot.v6bae6c3
@clerk/localizations	3.2.0-snapshot.v6bae6c3
@clerk/nextjs	5.8.0-snapshot.v6bae6c3
@clerk/clerk-react	5.11.1-snapshot.v6bae6c3
@clerk/remix	4.2.36-snapshot.v6bae6c3
@clerk/clerk-sdk-node	5.0.49-snapshot.v6bae6c3
@clerk/shared	2.10.0-snapshot.v6bae6c3
@clerk/tanstack-start	0.4.12-snapshot.v6bae6c3
@clerk/testing	1.3.10-snapshot.v6bae6c3
@clerk/themes	2.1.36-snapshot.v6bae6c3
@clerk/types	4.26.0-snapshot.v6bae6c3

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.3.13-snapshot.v6bae6c3 --save-exact

@clerk/backend

npm i @clerk/backend@1.13.9-snapshot.v6bae6c3 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.16-snapshot.v6bae6c3 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.27.0-snapshot.v6bae6c3 --save-exact

@clerk/elements

npm i @clerk/elements@0.16.0-snapshot.v6bae6c3 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.22-snapshot.v6bae6c3 --save-exact

@clerk/express

npm i @clerk/express@1.2.2-snapshot.v6bae6c3 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.52-snapshot.v6bae6c3 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.2.0-snapshot.v6bae6c3 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.8.0-snapshot.v6bae6c3 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.11.1-snapshot.v6bae6c3 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.36-snapshot.v6bae6c3 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.49-snapshot.v6bae6c3 --save-exact

@clerk/shared

npm i @clerk/shared@2.10.0-snapshot.v6bae6c3 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.4.12-snapshot.v6bae6c3 --save-exact

@clerk/testing

npm i @clerk/testing@1.3.10-snapshot.v6bae6c3 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.36-snapshot.v6bae6c3 --save-exact

@clerk/types

npm i @clerk/types@4.26.0-snapshot.v6bae6c3 --save-exact

…heet (#4291)

dstaley · 2024-10-07T18:54:06Z

!snapshot

clerk-cookie · 2024-10-07T18:58:50Z

Hey @dstaley - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.3.13-snapshot.v63f97d3
@clerk/backend	1.13.9-snapshot.v63f97d3
@clerk/chrome-extension	1.3.16-snapshot.v63f97d3
@clerk/clerk-js	5.27.0-snapshot.v63f97d3
@clerk/elements	0.16.0-snapshot.v63f97d3
@clerk/clerk-expo	2.2.22-snapshot.v63f97d3
@clerk/express	1.2.2-snapshot.v63f97d3
@clerk/fastify	1.0.52-snapshot.v63f97d3
@clerk/localizations	3.2.0-snapshot.v63f97d3
@clerk/nextjs	5.8.0-snapshot.v63f97d3
@clerk/clerk-react	5.11.1-snapshot.v63f97d3
@clerk/remix	4.2.36-snapshot.v63f97d3
@clerk/clerk-sdk-node	5.0.49-snapshot.v63f97d3
@clerk/shared	2.10.0-snapshot.v63f97d3
@clerk/tanstack-start	0.4.12-snapshot.v63f97d3
@clerk/testing	1.3.10-snapshot.v63f97d3
@clerk/themes	2.1.36-snapshot.v63f97d3
@clerk/types	4.26.0-snapshot.v63f97d3

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.3.13-snapshot.v63f97d3 --save-exact

@clerk/backend

npm i @clerk/backend@1.13.9-snapshot.v63f97d3 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.16-snapshot.v63f97d3 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.27.0-snapshot.v63f97d3 --save-exact

@clerk/elements

npm i @clerk/elements@0.16.0-snapshot.v63f97d3 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.22-snapshot.v63f97d3 --save-exact

@clerk/express

npm i @clerk/express@1.2.2-snapshot.v63f97d3 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.52-snapshot.v63f97d3 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.2.0-snapshot.v63f97d3 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.8.0-snapshot.v63f97d3 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.11.1-snapshot.v63f97d3 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.36-snapshot.v63f97d3 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.49-snapshot.v63f97d3 --save-exact

@clerk/shared

npm i @clerk/shared@2.10.0-snapshot.v63f97d3 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.4.12-snapshot.v63f97d3 --save-exact

@clerk/testing

npm i @clerk/testing@1.3.10-snapshot.v63f97d3 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.36-snapshot.v63f97d3 --save-exact

@clerk/types

npm i @clerk/types@4.26.0-snapshot.v63f97d3 --save-exact

dstaley · 2024-10-08T18:06:26Z

!snapshot

clerk-cookie · 2024-10-08T18:10:51Z

Hey @dstaley - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.3.13-snapshot.vc65ea96
@clerk/backend	1.13.9-snapshot.vc65ea96
@clerk/chrome-extension	1.3.17-snapshot.vc65ea96
@clerk/clerk-js	5.27.0-snapshot.vc65ea96
@clerk/elements	0.16.0-snapshot.vc65ea96
@clerk/clerk-expo	2.2.23-snapshot.vc65ea96
@clerk/express	1.2.2-snapshot.vc65ea96
@clerk/fastify	2.0.0-snapshot.vc65ea96
@clerk/localizations	3.2.1-snapshot.vc65ea96
@clerk/nextjs	5.8.0-snapshot.vc65ea96
@clerk/clerk-react	5.11.1-snapshot.vc65ea96
@clerk/remix	4.2.36-snapshot.vc65ea96
@clerk/clerk-sdk-node	5.0.49-snapshot.vc65ea96
@clerk/shared	2.10.0-snapshot.vc65ea96
@clerk/tanstack-start	0.4.12-snapshot.vc65ea96
@clerk/testing	1.3.10-snapshot.vc65ea96
@clerk/themes	2.1.36-snapshot.vc65ea96
@clerk/types	4.26.0-snapshot.vc65ea96

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.3.13-snapshot.vc65ea96 --save-exact

@clerk/backend

npm i @clerk/backend@1.13.9-snapshot.vc65ea96 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.17-snapshot.vc65ea96 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.27.0-snapshot.vc65ea96 --save-exact

@clerk/elements

npm i @clerk/elements@0.16.0-snapshot.vc65ea96 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.23-snapshot.vc65ea96 --save-exact

@clerk/express

npm i @clerk/express@1.2.2-snapshot.vc65ea96 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.0.0-snapshot.vc65ea96 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.2.1-snapshot.vc65ea96 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.8.0-snapshot.vc65ea96 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.11.1-snapshot.vc65ea96 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.36-snapshot.vc65ea96 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.49-snapshot.vc65ea96 --save-exact

@clerk/shared

npm i @clerk/shared@2.10.0-snapshot.vc65ea96 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.4.12-snapshot.vc65ea96 --save-exact

@clerk/testing

npm i @clerk/testing@1.3.10-snapshot.vc65ea96 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.36-snapshot.vc65ea96 --save-exact

@clerk/types

npm i @clerk/types@4.26.0-snapshot.vc65ea96 --save-exact

semgrep-app · 2024-10-15T17:42:46Z

GHSA-gp8f-8m3g-qvj9

+      canUseWindowHistoryAPIs ? window.history.pushState(null, '', path) : router.push(path, {});
+    },
+    pathname: () => window.location.pathname,
+    searchParams: () => new URLSearchParams(window.location.search),


Risk: Affected versions of next are vulnerable to Acceptance of Extraneous Untrusted Data With Trusted Data / Authorization Bypass Through User-Controlled Key.

Fix: Upgrade this library to at least version 14.2.10 at javascript/package-lock.json:45227.

Reference(s): GHSA-gp8f-8m3g-qvj9, CVE-2024-46982
_{Ignore this finding from ssc-adb055b9-fed0-4d70-a57d-eb9825b09449.}

semgrep-app · 2024-10-15T17:42:47Z

GHSA-gp8f-8m3g-qvj9

+    shallowPush(path: string) {
+      canUseWindowHistoryAPIs ? window.history.pushState(null, '', path) : router.push(path, {});
+    },
+    pathname: () => window.location.pathname,


Risk: Affected versions of next are vulnerable to Acceptance of Extraneous Untrusted Data With Trusted Data / Authorization Bypass Through User-Controlled Key.

Fix: Upgrade this library to at least version 14.2.10 at javascript/package-lock.json:45227.

Reference(s): GHSA-gp8f-8m3g-qvj9, CVE-2024-46982
_{Ignore this finding from ssc-adb055b9-fed0-4d70-a57d-eb9825b09449.}

semgrep-app · 2024-10-15T17:42:47Z

GHSA-gp8f-8m3g-qvj9

+    push: (path: string) => router.push(path),
+    replace: (path: string) =>
+      canUseWindowHistoryAPIs ? window.history.replaceState(null, '', path) : router.replace(path),
+    shallowPush(path: string) {


Risk: Affected versions of next are vulnerable to Acceptance of Extraneous Untrusted Data With Trusted Data / Authorization Bypass Through User-Controlled Key.

Fix: Upgrade this library to at least version 14.2.10 at javascript/package-lock.json:45227.

Reference(s): GHSA-gp8f-8m3g-qvj9, CVE-2024-46982
_{Ignore this finding from ssc-adb055b9-fed0-4d70-a57d-eb9825b09449.}

semgrep-app · 2024-10-15T17:42:48Z

GHSA-gp8f-8m3g-qvj9

+    mode: 'path',
+    name: 'NextRouter',
+    push: (path: string) => router.push(path),
+    replace: (path: string) =>


Risk: Affected versions of next are vulnerable to Acceptance of Extraneous Untrusted Data With Trusted Data / Authorization Bypass Through User-Controlled Key.

Fix: Upgrade this library to at least version 14.2.10 at javascript/package-lock.json:45227.

Reference(s): GHSA-gp8f-8m3g-qvj9, CVE-2024-46982
_{Ignore this finding from ssc-adb055b9-fed0-4d70-a57d-eb9825b09449.}

semgrep-app · 2024-10-15T17:42:49Z

GHSA-gp8f-8m3g-qvj9

+  return {
+    mode: 'path',
+    name: 'NextRouter',
+    push: (path: string) => router.push(path),


Risk: Affected versions of next are vulnerable to Acceptance of Extraneous Untrusted Data With Trusted Data / Authorization Bypass Through User-Controlled Key.

Fix: Upgrade this library to at least version 14.2.10 at javascript/package-lock.json:45227.

Reference(s): GHSA-gp8f-8m3g-qvj9, CVE-2024-46982
_{Ignore this finding from ssc-adb055b9-fed0-4d70-a57d-eb9825b09449.}

Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com> Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com> Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com> Co-authored-by: panteliselef <panteliselef@outlook.com> Co-authored-by: Jacek Radko <jacekradko@gmail.com>

brkalow added 3 commits September 5, 2024 17:23

update clerk/ui for rendering

9e71651

fix host router issue

8f3ea4b

new ui renderer

b3ee721

clerk-cookie added clerk-js nextjs elements labels Sep 5, 2024

brkalow added 3 commits September 5, 2024 21:13

refactor component renderer, add sign up

851f201

remove unused function

371f6ee

add another comment

b8d014f

nikosdouvlis reviewed Sep 6, 2024

View reviewed changes

Comment thread packages/nextjs/src/app-router/client/ClerkProvider.tsx

brkalow and others added 6 commits September 6, 2024 13:20

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

56af4f5

tweak webpack chunk settings

f0c6f51

fix bring back isSubmitting boolean

2fdd33e

update sideEffects to enable loading css file

5322329

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

b9b3359

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

e3132e3

dstaley mentioned this pull request Sep 20, 2024

feat(clerk-js): Add bundle-check script #4199

Merged

9 tasks

feat(clerk-js,types,shared): Add necessary types for new UI

f000689

clerk-cookie added the types label Sep 24, 2024

dstaley added 10 commits September 23, 2024 21:28

chore(repo): Add changeset

9866b16

fix(clerk-js): Add dependency on @clerk/ui

812035a

chore(clerk-js): Temporarily increase bundlewatch limits

da7ba53

chore(clerk-js): Temporarily increase bundlewatch limits

3fe0bda

fix(clerk-js): Ensure CJS script doesn't contain ESM code

9542bab

fix(ui): Mark package as public

a75375f

fix(nextjs): Pass correct router option

7f71197

fix(clerk-js): Emit CJS chunks as CJS

31d749c

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

4b6c093

fix(clerk-js): Only instantiate new UI if Clerk is loaded

86419e0

dstaley added 3 commits October 4, 2024 13:20

fix(nextjs): Do not export useNextRouter

3d6d9ae

feat(clerk-js): Add support for loading UI styles as first CSS styles…

74c81bf

…heet (#4291)

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

63f97d3

dstaley added 4 commits October 7, 2024 12:10

fix(clerk-js): Ensure import.meta.url isn't used in CJS build

4746fb4

fix(clerk-js): Restore minimization

54a836c

fix(clerk-js): Bundle CSS into CJS and ESM bundles (#4301)

29258d0

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

c65ea96

brkalow and others added 3 commits October 10, 2024 19:17

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

bab0ad3

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

129bc20

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

98fb7db

semgrep-app Bot reviewed Oct 15, 2024

View reviewed changes

dstaley added 6 commits October 15, 2024 10:48

fix(ui): Fix package.json

62dbb34

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

dc4149e

fix(elements): Move shared back to dependencies

163ef01

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

5035d98

Merge branch 'main' into brk.feat/render-ui-in-clerk-js

6316ccd

fix(elements: Use latest version of shared

1574014

dstaley merged commit 3b50b67 into main Oct 17, 2024

dstaley deleted the brk.feat/render-ui-in-clerk-js branch October 17, 2024 19:58

clerk-cookie mentioned this pull request Oct 17, 2024

ci(repo): Version packages #4358

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(clerk-js): Render `@clerk/ui` - #4114

feat(clerk-js): Render `@clerk/ui`#4114
dstaley merged 57 commits into
mainfrom
brk.feat/render-ui-in-clerk-js

brkalow commented Sep 5, 2024

Uh oh!

changeset-bot Bot commented Sep 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

clerk-cookie commented Oct 4, 2024

Uh oh!

dstaley commented Oct 7, 2024

Uh oh!

clerk-cookie commented Oct 7, 2024

Uh oh!

dstaley commented Oct 8, 2024

Uh oh!

clerk-cookie commented Oct 8, 2024

Uh oh!

semgrep-app Bot Oct 15, 2024

Uh oh!

semgrep-app Bot Oct 15, 2024

Uh oh!

semgrep-app Bot Oct 15, 2024

Uh oh!

semgrep-app Bot Oct 15, 2024

Uh oh!

semgrep-app Bot Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

brkalow commented Sep 5, 2024

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

clerk-cookie commented Oct 4, 2024

Uh oh!

dstaley commented Oct 7, 2024

Uh oh!

clerk-cookie commented Oct 7, 2024

Uh oh!

dstaley commented Oct 8, 2024

Uh oh!

clerk-cookie commented Oct 8, 2024

Uh oh!

semgrep-app Bot Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

semgrep-app Bot Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

semgrep-app Bot Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

semgrep-app Bot Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

semgrep-app Bot Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

changeset-bot Bot commented Sep 5, 2024 •

edited

Loading